Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cgroup1/ to make cgroup1 and cgroup2 symmmetric #255

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

kzys
Copy link
Member

@kzys kzys commented Nov 8, 2022

No description provided.

kzys added 2 commits November 8, 2022 02:28
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@@ -14,7 +14,7 @@
limitations under the License.
*/

package cgroups
package cgroup1

// State is a type that represents the state of the current cgroup
type State string
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to share types like State between cgroup1 and cgroup2?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary to share

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@kzys kzys marked this pull request as ready for review November 8, 2022 04:51
@kzys kzys merged commit cc78c6c into containerd:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants